-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: [M3-8331] - useToastNotification async toasts #10841
refactor: [M3-8331] - useToastNotification async toasts #10841
Conversation
Coverage Report: ✅ |
28db55a
to
a655ac4
Compare
@pmakode-akamai Hey Purvesh, just a heads up that this PR seems to be causing a handful of test failures -- at a glance they seem to be caused by toast notifications for certain events not appearing when Cloud expects them to appear |
Hey Joe (@jdamore-linode), this PR is still WIP. I’ll be looking into the test failures related to the toast notifications and will address them soon. Thanks! |
0d10cf4
to
908d1ce
Compare
packages/manager/cypress/e2e/core/linodes/linode-storage.spec.ts
Outdated
Show resolved
Hide resolved
packages/manager/cypress/e2e/core/linodes/linode-storage.spec.ts
Outdated
Show resolved
Hide resolved
9af075e
to
3f008f4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx for the changes - API is much cleaner now and implementation looks good and well test. Approving pending a few improvements and fixes
packages/manager/cypress/e2e/core/linodes/resize-linode.spec.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thank you
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice cleanup! 🎉
✅ confirmed tests pass
✅ confirmed event messaging
✅ confirmed toasts for the flows mentioned
** caveat - I mainly tested for success toasts and don't really know how to trigger a lot of the failure toasts. However, I did see the snapshot failed toast + ran machine-image-upload.spec.ts
a couple of times to see the failed toast for image upload ... will be trying to trigger the rest of the failure toasts 🤞
403b862
to
1e74206
Compare
Description 📝
const toasts: Toasts = { ... }
should be moved to the event directory and map to event messages already defined in our new factory.Changes 🔄
useToastNotification
.const toasts: Toasts = { ... }
toEvents/asyncToasts.tsx
.Events/factories/disk.tsx
.Target release date 🗓️
N/A
How to test 🧪
Verification steps
Events/factories
As an Author I have considered 🤔
Check all that apply